Messages in this thread Patch in this message | | | Subject | Re: [patch] kobject_uevent: fix init ordering | From | Robert Love <> | Date | Thu, 04 Nov 2004 14:28:52 -0500 |
| |
On Thu, 2004-11-04 at 13:27 -0500, Robert Love wrote:
> Looks like kobject_uevent_init is executed before netlink_proto_init and > consequently always fails. Not cool. > > Attached patch switches the initialization over from core_initcall (init > level 1) to postcore_initcall (init level 2). Netlink's initialization > is done in core_initcall, so this should fix the problem. We should be > fine waiting until postcore_initcall. > > Also a couple white space changes mixed in, because I am anal.
Greg, sir, here is a patch rediff'ed off current BK.
Robert Love
fix init call ordering for kobject_uevent
Signed-Off-By: Robert Love <rml@novell.com>
lib/kobject_uevent.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
diff -urN linux-2.6.10-rc1-bk14/lib/kobject_uevent.c linux/lib/kobject_uevent.c --- linux-2.6.10-rc1-bk14/lib/kobject_uevent.c 2004-11-04 14:20:10.431943792 -0500 +++ linux/lib/kobject_uevent.c 2004-11-04 14:26:54.056583520 -0500 @@ -120,9 +120,8 @@ sprintf(attrpath, "%s/%s", path, attr->name); rc = send_uevent(signal, attrpath, NULL, gfp_mask); kfree(attrpath); - } else { + } else rc = send_uevent(signal, path, NULL, gfp_mask); - } exit: kfree(path); @@ -148,7 +147,6 @@ { return do_kobject_uevent(kobj, action, attr, GFP_ATOMIC); } - EXPORT_SYMBOL_GPL(kobject_uevent_atomic); static int __init kobject_uevent_init(void) @@ -164,7 +162,7 @@ return 0; } -core_initcall(kobject_uevent_init); +postcore_initcall(kobject_uevent_init); #else static inline int send_uevent(const char *signal, const char *obj,
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |