Messages in this thread | | | Date | Wed, 1 Dec 2004 05:54:22 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] dm: remove unused functions (fwd) |
| |
On Tue, Nov 30, 2004 at 11:05:25PM +0000, Alasdair G Kergon wrote: > On Mon, Nov 29, 2004 at 03:29:40AM +0100, Adrian Bunk wrote: > > Please apply or comment on it. > > Please check *why* the functions aren't used first. > > e.g. An alloc function with a corresponding free that > never gets called suggests a leak to me...
I have to admit that I don't thoroughly check the code where I find unused code. That's why I asked for comments on this patch. Ususally the maintainers of the code in question know best whether such a patch is correct or not.
Simply consider my patches as some kind of "list of unused functions".
> Alasdair
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |