Messages in this thread | | | Subject | Re: [1/7] Xen VMM #3: add ptep_establish_new to make va available | Date | Tue, 30 Nov 2004 23:05:45 +0000 | From | Ian Pratt <> |
| |
> On Tue, 2004-11-30 at 02:06 +0000, Ian Pratt wrote: > > This patch adds 'ptep_establish_new', in keeping with the > > existing 'ptep_establish', but for use where a mapping is being > > established where there was previously none present. This > > function is useful (rather than just using set_pte) because > > having the virtual address available enables a very important > > optimisation for arch-xen. We introduce > > HAVE_ARCH_PTEP_ESTABLISH_NEW and define a generic implementation > > in asm-generic/pgtable.h, following the pattern of the existing > > ptep_establish. > > I would rather move toward that patch that David Miller proposed a while > ago that makes sure the necessary infos (mm, address, ...) are always > passed to all PTE functions.
I'd appreciate a pointer to the patch.
It may still be of some use to distinguish between call sites where it is likely that mm == current->mm to avoid adding a futile test in all the others.
> Is there also a need for ptep_establish and ptep_establish_new to be 2 > different functions ?
They allow different TLB invalidation behaviour. I guess it could be one function with an extra arg.
Ian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |