lkml.org 
[lkml]   [2004]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/14] FRV: Make calibrate_delay() optional
On Tue, Nov 02, 2004 at 04:29:39PM +0000, David Howells wrote:
>
> > this changelog certainly does not apply to the delay loop calibration.
>
> I just duplicated the banners from init/main.c and tacked some extra bits on
> the front.
>
> > any reason it's in lib? Better move this to kernel and properly compile
> > it conditionally.
>
> So that it get built and placed in an archive library, thus allowing the
> linker to decide whether to include it or not, without having to use
> conditional stuff and without having to change every other arch to enable it.
>
> I suppose I could do something like this in init/Makefile:
>
> if ($(CONFIG_DISABLE_GENERIC_CALIBRATE_DELAY),y)
> obj-y += calibrate.o
> endif
>
> That would allow me to avoid having to change all the archs.

Use CONFIG_CALIBRATE_DELAY and add it to all other ports. Remember Linux
is not about least intrusive changes but about what's easiest maintainable.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.060 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site