lkml.org 
[lkml]   [2004]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix HPET time_interpolator registration
On Wed, 3 Nov 2004, Andrew Morton wrote:

> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> >
> > Fixup after mid-air collision between Christoph adding time_interpolator.mask,
> > and me removing a static time_interpolator struct from hpet.
> >
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> >
> > ===== drivers/char/hpet.c 1.14 vs edited =====
> > --- 1.14/drivers/char/hpet.c 2004-11-02 07:40:42 -07:00
> > +++ edited/drivers/char/hpet.c 2004-11-03 10:05:26 -07:00
> > @@ -712,6 +712,7 @@
> > ti->addr = &hpetp->hp_hpet->hpet_mc;
> > ti->frequency = hpet_time_div(hpets->hp_period);
> > ti->drift = ti->frequency * HPET_DRIFT / 1000000;
> > + ti->mask = 0xffffffffffffffffLL;
> >
> > hpetp->hp_interpolator = ti;
> > register_time_interpolator(ti);
> >
>
> ti->mask is u64, and on some architectures u64 is `long'. Compilers might
> whine about this. I'll make it
>
> ti->mask = -1;
>
> which just works.

Hmmm... How do you then specify a 64 bit mask without running into issues
with the compilers?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.060 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site