Messages in this thread | | | Date | Mon, 29 Nov 2004 14:23:23 -0800 | From | Greg KH <> | Subject | Re: [PATCH] CKRM: 5/10 CKRM: Task based management for CPU, memory and Disk I/O. |
| |
On Mon, Nov 29, 2004 at 10:49:09AM -0800, Gerrit Huizenga wrote: > +#define TC_DEBUG(fmt, args...) do { \ > +/* printk("%s: " fmt, __FUNCTION__ , ## args); */ } while (0)
Again with the new debug macro :(
> +static struct ckrm_task_class taskclass_dflt_class = { > +};
Empty structure? Why?
> +// Hubertus .. following functions should move to ckrm_rc.h
Why haven't they moved :)
> +static inline void ckrm_task_lock(struct task_struct *tsk) > +{ > + spin_lock(&tsk->ckrm_tsklock); > +}
Just lock (or unlock) the lock, don't wrap a lock in a function.
> +DECLARE_MUTEX(async_serializer); // serialize all async functions
Should this really be global? The code says otherwise :)
> + printk("...... Initializing ClassType<%s> ........\n", > + CT_taskclass.name);
What a pretty log message. Unfortunately it's wrong (me hears the growing mumblings of the kernel janitor mob...)
> +#if 0 > + > +/****************************************************************************** > + * Debugging Task Classes: Utility functions > + ******************************************************************************/
Then remove the code, if it's not needed.
> +EXPORT_SYMBOL(tcp_v4_lookup_listener);
Not EXPORT_SYMBOL_GPL()?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |