Messages in this thread | | | Subject | Re: Suspend 2 merge: 17/51: Disable MCE checking during suspend. | From | Nigel Cunningham <> | Date | Fri, 26 Nov 2004 09:38:24 +1100 |
| |
Hi.
On Fri, 2004-11-26 at 09:31, Pavel Machek wrote: > Hi! > > > > > Avoid a potential SMP deadlock here. > > > > > > ..and loose MCE report. > > > > Deadlock or get an MCE report and do a printk when we're shutting down > > anyway? > > If MCE happens, I'd like user to report it. Loosing it is wrong, > deadlocking may be actually better because at least you get the > report. I'd BUG(). > > MCEs are hardware problem, right? They should not be common.
It's not them occurring that's the problem, it's checking for them that involves an SMP call :<
> static void mce_work_fn(void *data) > { > if (!test_suspend_state(SUSPEND_RUNNING)) > on_each_cpu(mce_checkregs, NULL, 1, 1); > schedule_delayed_work(&mce_work, MCE_RATE); > }
Nigel -- Nigel Cunningham Pastoral Worker Christian Reformed Church of Tuggeranong PO Box 1004, Tuggeranong, ACT 2901
You see, at just the right time, when we were still powerless, Christ died for the ungodly. -- Romans 5:6
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |