Messages in this thread | | | Subject | Re: [2.6 patch] sstfb.c: make some code static | From | Alan Cox <> | Date | Wed, 24 Nov 2004 22:49:47 +0000 |
| |
On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote: > The patch below makes some needlessly global code static.
No it doesn't. It makes some functions static (which is fine) and adds some nasty messy pointless #ifdefs. It touches no variable at all.
Please check your description texts and also don't fill the kernel with ifdef crap. Probably the __setup stuff should be a module param new style too.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |