Messages in this thread Patch in this message | | | Date | Wed, 24 Nov 2004 15:37:59 -0800 | From | Greg KH <> | Subject | Re: Oops in visor, since 2.6.10-rc1 |
| |
On Fri, Nov 19, 2004 at 02:53:42PM +0000, Lu?s Pinto wrote: > > This sort of solves part of it. It doesn't oops anymore, > however, for a 'pilot-xfer -l' (list all databases on palm) or > a 'pilot-xfer -i xyz.pdb' (install a database on palm) it > freezes at the middle, and the palm eventually times out. Here > goes the corresponding dmesg: the first time it didn't do > nothing (pilot-xfer didn't even start), the second and third > it freezed.
Please try this patch. It should solve the problem for you. Sorry for all of the problems with these recent changes.
thanks,
greg k-h
[PATCH] USB visor: Don't count outstanding URBs twice
Incrementing the outstanding_urbs counter twice for the same URB can't be good. No wonder Simon didn't get far syncing his Palm.
Signed-off-by: Roger Luethi <rl@hellgate.ch> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
diff -Nru a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c --- a/drivers/usb/serial/visor.c 2004-11-24 15:36:25 -08:00 +++ b/drivers/usb/serial/visor.c 2004-11-24 15:36:25 -08:00 @@ -497,7 +497,6 @@ dev_dbg(&port->dev, "write limit hit\n"); return 0; } - ++priv->outstanding_urbs; spin_unlock_irqrestore(&priv->lock, flags); buffer = kmalloc (count, GFP_ATOMIC); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |