Messages in this thread | | | From | Nikita Danilov <> | Date | Thu, 25 Nov 2004 00:53:52 +0300 | Subject | Re: [PATCH]: 1/4 batch mark_page_accessed() |
| |
Marcelo Tosatti writes: > > Hi Nikita,
Hello, Marcelo,
>
[...]
> > + if (pagezone != zone) { > > + if (zone) > > + local_unlock_irq(&zone->lru_lock); > > You surely meant spin_{un}lock_irq and not local{un}lock_irq.
Oh, you are right. local_lock_* are functions to manipulate "local wait" spin-lock variety that was introduced by some other patch. batch-mark_page_accessed patch worked only because all references to local_lock_* functions were removed by pvec-cleanup patch.
Another proof of the obvious fact that manually coded pagevec iteration is evil. :)
> > Started the STP tests on 4way/8way boxes.
Great.
Nikita. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |