lkml.org 
[lkml]   [2004]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Suspend 2 merge: 34/51: Includes
    From
    Date
    Hi.

    On Thu, 2004-11-25 at 00:25, Christoph Hellwig wrote:
    > please submit header changes together with the matching code changes.

    I can split them a little, but most of these suspend2 specific includes
    are used by multiple files. Ranges, for example, are used everywhere.

    > And all this plugin thingies in here look like overengineering.

    I can see that it might look that way, but it's actually fundamental to
    the support for building as modules (which is required for LVM &
    encryption), and has been really helpful in creating clear distinctions
    between the different parts of suspend. It also provides a clear method
    for someone to add support for their new wizz-bang storage method or
    compressor.

    Regards,

    Nigel
    --
    Nigel Cunningham
    Pastoral Worker
    Christian Reformed Church of Tuggeranong
    PO Box 1004, Tuggeranong, ACT 2901

    You see, at just the right time, when we were still powerless, Christ
    died for the ungodly. -- Romans 5:6

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:4.736 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site