Messages in this thread | | | Date | Wed, 24 Nov 2004 08:34:30 +0100 | From | Colin Leroy <> | Subject | Re: [PATCH] let fat handle MS_SYNCHRONOUS flag |
| |
On 23 Nov 2004 at 19h11, Matt Mackall wrote:
Hi,
> BUG_ON(!bh); > sync_dirty_buffer(bh); > brelse(bh);
I wasn't sure sync_dirty_buffer and brelse checked for nullity :)
> Concept seems good, and the implementation otherwise looks good at > first glance.
Cool :) Should I submit an updated patch to Andrew for -mm ?
Thanks for all the comments. I agree with what most people said, sync mode is not a guarantee that everything will be fine, but it helps in most cases.
As for the speed, from what I checked it slows down IO a bit, of course, but that is within tolerable bounds imho. -- Colin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |