Messages in this thread | | | Subject | Re: 2.6.10-rc2 doesn't boot (if no floppy device) | From | Len Brown <> | Date | 23 Nov 2004 02:06:26 -0500 |
| |
On Mon, 2004-11-22 at 23:57, Linus Torvalds wrote: > > On Mon, 22 Nov 2004, Linus Torvalds wrote: > >
> Len, how about this patch - it re-enables the link disable and then > re-codes the ELCR setting to match. > > Basically it just computes the new ELCR: if acpi_noirq is set, it > leaves it at the old value, otherwise it zeroes it - and in both cases > it fixes the SCI entry.
> Your argument for doing this ended up being convincing, so the only > difference between this and your debug patch is really just the > obvious organizational ones, and the test for "acpi_noirq", which I > think is needed (since if acpi_noirq is set, we're not going to > disable and re-enable the PCI interrupts, so we'll just have to trust > ELCR).
I think your use of acpi_noirq in acpi_pic_sci_set_trigger() was clever -- maybe more clever than the name of the routine suggests -- but it looks correct.
thanks for restoring pci_link.c
-Len
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |