Messages in this thread Patch in this message | | | Date | Tue, 23 Nov 2004 20:36:04 +0100 | From | Roger Luethi <> | Subject | [2.6 PATCH] visor: Don't count outstanding URBs twice |
| |
Guys, can you please CC me when discussing patches of mine? I don't read LKML religiously, and my procmail filters are pretty dumb. Thanks. So my previous patch fixed the oops, but the driver's still borked.
Incrementing the outstanding_urbs counter twice for the same URB can't be good. No wonder Simon didn't get far syncing his Palm.
Signed-off-by: Roger Luethi <rl@hellgate.ch>
--- linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c.orig 2004-11-23 20:23:27.592097112 +0100 +++ linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c 2004-11-23 20:24:53.496037728 +0100 @@ -497,7 +497,6 @@ static int visor_write (struct usb_seria dev_dbg(&port->dev, "write limit hit\n"); return 0; } - ++priv->outstanding_urbs; spin_unlock_irqrestore(&priv->lock, flags); buffer = kmalloc (count, GFP_ATOMIC); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |