Messages in this thread | | | Date | Tue, 23 Nov 2004 10:37:24 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c |
| |
On Tue, 23 Nov 2004, Jesper Juhl wrote: > > Shutting up gcc is not the primary goal here, the goal is/was to > a) review the code and make sure that it is safe and correct, and fix it > when it is not. > b) remove comparisons that are just a waste of CPU cycles when the result > is always true or false (in *all* cases on *all* archs).
Well, I'm convinced that (b) is unnecessary, as any compiler that notices the range thing enough to warn will also be smart enough to just remove the test internally.
But yes, as long as the thing is a "review and fix bugs" and not a quest to remove warnings which may well be compiler figments, that's obviously ok.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |