Messages in this thread | | | Date | Mon, 22 Nov 2004 20:40:03 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH][RFC/v1][8/12] Add IPoIB (IP-over-InfiniBand) driver |
| |
More nitpicking..
Sam
> +++ linux-bk/drivers/infiniband/Makefile 2004-11-21 21:25:56.794775182 -0800 > @@ -1,2 +1,3 @@ > obj-$(CONFIG_INFINIBAND) += core/ No reason to use $(CONFIG_INFINIBAND) here - it's already done in drivers/infiniband/Makefile
> +EXTRA_CFLAGS += -Idrivers/infiniband/include This will get killed if you move the include files...
+ > +obj-$(CONFIG_INFINIBAND_IPOIB) += ib_ipoib.o > + > +ib_ipoib-y := ipoib_main.o \ > + ipoib_ib.o \ > + ipoib_multicast.o \ > + ipoib_verbs.o \ > + ipoib_vlan.o One or two lines.
> +#include <asm/semaphore.h> > + > +#include "ipoib_proto.h" Shoulb be included as the last file - since it's the most local one. > + > +#include <ib_verbs.h> > +#include <ib_pack.h> > +#include <ib_sa.h> > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |