Messages in this thread | | | Date | Mon, 22 Nov 2004 10:01:54 -0800 | From | Nishanth Aravamudan <> | Subject | Re: [PATCH 2/2] include/delay.h: replace msleep() and msleep_interruptible() with macros |
| |
On Sat, Nov 20, 2004 at 10:37:21AM +0100, Oliver Neukum wrote: > Am Samstag, 20. November 2004 02:23 schrieb Nishanth Aravamudan: > > Description: Remove prototypes of msleep() and msleep_interruptible() to > > prepare for the macro versions of these functions. Add macros for 4 > > types of sleeps: > > What is the purpose of having macros for delay? > They are on a slow path by definition. You want the smallest possible > function call here, nothing fancy.
Just so I'm clear on what you are asking... Do you mean why am I using macros or why the macros are needed at all?
To the former, I am more than happy to change them to functions, and, in fact, I believe I have to for modules (EXPORT_SYMBOL_GPL?) to be able to call the sleep functions.
To the latter, having these 4 functions/macros makes it clear for what reason you are sleeping. It leads to *correct* functionality of the code, which we do not currently have.
-Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |