Messages in this thread | | | Date | Sun, 21 Nov 2004 16:12:44 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 475] HP300 LANCE |
| |
Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, 16 Nov 2004, Andrew Morton wrote: > > Christoph Hellwig <hch@infradead.org> wrote: > > > > There's tons of leaks in the hplcance probing code, and it doesn't release > > > > he memory region on removal either. > > > > > > > > Untested patch to fix those issues below: > > > > > > ping. > > > > The fix needs a fix: > > Indeed. > > And you should remove the definitions of dio_resource_{start,len}(), as they're > already defined in linux/dio.h. >
But differently. Christoph had:
+#define dio_resource_len(d) \ + ((d)->resource.end - (d)->resource.start)
but dio.h has:
#define dio_resource_len(d) ((d)->resource.end-(z)->resource.start+1)
Which is correct? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |