lkml.org 
[lkml]   [2004]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch] 2.6.10-rc2-mm2: MTD_XIP dependencies
On Fri, Nov 19, 2004 at 11:35:26AM -0500, Nicolas Pitre wrote:
> On Fri, 19 Nov 2004, Adrian Bunk wrote:
>
> >...
> > The Kconfig file should express all dependencies of a driver.
> > If a driver doesn't compile, it should not be selectable - and not
> > #error at compile time.
>
> Absolutely!

Good that we agree. :-)

> So please would you just ask Andrew to apply the following patch and be
> happy? Thank you.

A slightly improved patch is below.

> --- ./drivers/mtd/chips/Kconfig.orig Fri Nov 19 11:25:45 2004
> +++ ./drivers/mtd/chips/Kconfig Fri Nov 19 11:28:08 2004
> @@ -274,8 +274,7 @@
>
> config MTD_XIP
> bool "XIP aware MTD support"
> - depends on !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
> - default y if XIP_KERNEL
> + depends on XIP_KERNEL && !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
> help
> This allows MTD support to work with flash memory which is also
> used for XIP purposes. If you're not sure what this is all about
>
>
> Nicolas


cu
Adrian

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.10-rc2-mm2-full/drivers/mtd/chips/Kconfig.old 2004-11-18 16:35:40.000000000 +0100
+++ linux-2.6.10-rc2-mm2-full/drivers/mtd/chips/Kconfig 2004-11-21 20:54:43.000000000 +0100
@@ -274,8 +274,8 @@

config MTD_XIP
bool "XIP aware MTD support"
- depends on !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
- default y if XIP_KERNEL
+ depends on XIP_KERNEL && !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL && (ARCH_SA1100 || ARCH_PXA || BROKEN)
+ default y
help
This allows MTD support to work with flash memory which is also
used for XIP purposes. If you're not sure what this is all about
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.050 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site