lkml.org 
[lkml]   [2004]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] small input cleanup
On Sun, Nov 21, 2004 at 06:48:33PM +0100, Adrian Bunk wrote:

> > Well, it works in its current form, and drivers should call it when
> > their reinit logic fails to reinitialize the device. They don't, which
> > is a bug, and should be fixed. I don't think removing gameport_rescan()
> > will help fixing them.
>
> Fine with me.
>
> > > - could ps2_sendbyte be #ifdef 0'ed until it's required?
> > > this way, it wouldn't make the kernel bigger today
> >
> > It is used, just not outside libps2. Does the EXPORT_SYMBOL() make the
> > kernel so much bigger?
>
> It doesn't make a big difference, but if an EXPORT_SYMBOL isn't required
> (and won't be required in the near future), where's the point keeping
> it?
>
> The situation is clearly different if in-kernel users from other files
> will be added in the near future.

So far all devices only need proper commands per PS/2 specification. The
export is there in case some device will need to be sent separate bytes
outside the command structure.

--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.035 / U:3.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site