Messages in this thread Patch in this message | | | Date | Sat, 20 Nov 2004 13:16:23 +0100 | From | Jean Delvare <> | Subject | [PATCH 2.4] I2C updates for 2.4.28 (2/5) |
| |
Original report and discussion: http://archives.andrew.net.au/lm-sensors/msg28053.html
Bottom line: The real parser in i2c-proc is partly broken, but in a way it will go unnoticed in most cases (thus unspotted so far). Still worth fixing IMHO.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
--- linux-2.4.28-pre4/drivers/i2c/i2c-proc.c.orig 2004-10-16 12:44:30.000000000 +0200 +++ linux-2.4.28-pre4/drivers/i2c/i2c-proc.c 2004-10-16 12:46:38.000000000 +0200 @@ -540,7 +540,7 @@ /* Skip everything until we hit whitespace */ while (bufsize && !((ret=get_user(nextchar, (char *) buffer))) && - isspace((int) nextchar)) { + !isspace((int) nextchar)) { bufsize--; ((char *) buffer)++; }
-- Jean Delvare http://khali.linux-fr.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |