Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 8/14] FRV: GP-REL data support | Date | Tue, 02 Nov 2004 16:34:01 +0000 |
| |
> > +#ifdef CONFIG_FRV > > +#define __jiffy_data __attribute__((section(".data"))) > > +#else > > +#define __jiffy_data > > +#endif > > please avoid per-arch ifdefs in common code, this needs to go into some asm/ > header, or and __ARCH_HAVE_FOO ifdef.
You're advocating using an ifdef? I thought you hated the things...
I want to avoid changing every other arch.
> Anyway, would doing this unconditionally cause any problems?
Not as far as I know.
> > +#ifndef __ASSEMBLY__ > > +extern const char linux_banner[]; > > +#endif > > totally wrong place. this is not about linkage at all.
Actually, it's almost entirely about linkage:-) But in this case, you may be right. Anyone any suggestions as to the right place for this? linux/kernel.h perhaps?
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |