Messages in this thread | | | Date | Tue, 2 Nov 2004 08:02:11 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Semaphore assembly-code bug |
| |
On Tue, 2 Nov 2004, linux-os wrote: > > The patch you provided patched without any rejects. However, > the system won't boot.
Yes, there was a incorrect change to the "asmlinkage" definition that I had played with before deciding to make just the semaphores be reg-arg, and that change made it into my original patch by mistake. I sent out a second message asking people to remove that part of the patch some time later, but..
> I patched Linux-2.6.9. Could you please review your patch? > I will await the possibility of a simple typo that I can > fix by hand before reverting.
Just change the incorrect "3" in <asm-i386/linkage.h> (or whatever, this is from memory):
#define asmlinkage CPP_ASMLINKAGE __attribute__((regparm(3)))
back to a "0". Asmlinkage still uses stack-based parameter passing, which I'd love to fix eventually (we've had bugs in that area too), but it is just too much pain to do right now.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |