Messages in this thread | | | Date | Fri, 19 Nov 2004 15:06:47 -0700 | From | Tom Rini <> | Subject | Re: [PATCH] Additional kgdb hooks |
| |
On Tue, Nov 09, 2004 at 03:29:28PM -0800, George Anzinger wrote: > Andrew Morton wrote: > >dhowells@redhat.com wrote: > > > >>The attached patch adds a couple of extra hooks by which kgdb or an > >>equivalent > >>gdbstub can catch bad_page() and panic() invocations. > > > > > >Tom is valiantly flogging his way through a generic KGDB implementation. I > >think it would be better to push ahead with that and to not put into > >generic code hooks which are specific to one arch's kgdb implementation. > > IMNSHO the trap should be in dump_stack(). That way it catches a bunch of > things all at once.
The hard question is how to do this cleanly. Perhaps changing things slightly so that lib/dump_stack.c provides the 'true' dump_stack() (or moving it to kernel/dump_stack.c) which calls a notify chain and then arch_dump_stack() ?
> Also, panic has a notify option that kgdb should use just like everybody > else.
This is a good idea, I'm surprised we didn't already do, so I've just done it.
-- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |