lkml.org 
[lkml]   [2004]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] 2.6.10-rc2-mm2: MTD_XIP dependencies
On Fri, 19 Nov 2004, Adrian Bunk wrote:

> On Thu, Nov 18, 2004 at 05:31:32PM -0500, Nicolas Pitre wrote:
> >...
> > Can we make it conditional on CONFIG_XIP_KERNEL instead?
> > It would be less messy IMHO.
>
> I copied the dependency from the #ifdef before the #error.
>
> The #error should either go or be the same than the Kconfig dependency.

And on what basis? This just doesn't make sense.

CONFIG_MTD_XIP is there to be compatible with kernels which are made
XIP. This currently means _all_ ARM flavours the kernel currently
supports. Yet there is only SA11x0 and PXA2xx which have proper MTD_XIP
primitives ence the #error.

My position is therefore that the CONFIG_MTD_XIP should depend on
CONFIG_XIP_KERNEL since this is what it is for, and the #error stay as
is. If ever you make x86 kernel XIPable you'll need to add the missing
bits guarded by the #error anyway.

And no, allyesconfig makes little sense on ARM as it has been discussed
on lkml before.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.147 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site