lkml.org 
[lkml]   [2004]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2] Xen core patch : arch_free_page return value
One tiny suggestion...

Ian Pratt wrote:
> -void arch_free_page(struct page *page, int order)
> +int arch_free_page(struct page *page, int order)

How about just changing that to...

void __arch_free_page(struct page *page, int order)

... and leave the rest of the function alone. Then:

> -extern void arch_free_page(struct page *page, int order);
> +extern int arch_free_page(struct page *page, int order);

Do...

extern void __arch_free_page(struct page *page, int order);
#define arch_free_page(page, order) (__arch_free_page((page), (order)), 0)

That way the compiler can omit the "if(...) return" even on UML

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.048 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site