Messages in this thread | | | Date | Thu, 18 Nov 2004 00:37:52 -0800 | From | Mitchell Blank Jr <> | Subject | Re: [patch 2] Xen core patch : arch_free_page return value |
| |
One tiny suggestion...
Ian Pratt wrote: > -void arch_free_page(struct page *page, int order) > +int arch_free_page(struct page *page, int order)
How about just changing that to...
void __arch_free_page(struct page *page, int order)
... and leave the rest of the function alone. Then:
> -extern void arch_free_page(struct page *page, int order); > +extern int arch_free_page(struct page *page, int order);
Do...
extern void __arch_free_page(struct page *page, int order); #define arch_free_page(page, order) (__arch_free_page((page), (order)), 0)
That way the compiler can omit the "if(...) return" even on UML
-Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |