Messages in this thread | | | Date | Wed, 17 Nov 2004 12:21:23 -0800 | From | Andrew Morton <> | Subject | Re: Dropped patch: mm/mempolicy.c:sp_lookup() |
| |
Hugh Dickins <hugh@veritas.com> wrote: > > On Wed, 17 Nov 2004, Andrew Morton wrote: > > Andi Kleen <ak@suse.de> wrote: > > > On Tue, Nov 16, 2004 at 10:54:09PM -0500, Chuck Ebbert wrote: > > > > On Wed, 17 Nov 2004 at 02:00:20 +0100, Andi Kleen wrote: > > > > > On Mon, Nov 15, 2004 at 11:15:51PM -0500, Chuck Ebbert wrote: > > > > > > Andrea posted this one-liner a while ago as part of a larger patch. He said > > > > > > it fixed return of the wrong policy in some conditions. Was this a valid fix? > > > > > > > > > > Yes it was. > > > > > > > > At least it wasn't dropped -- it's in -mm as part of > > > > fix-for-mpol-mm-corruption-on-tmpfs, though it's unrelated to tmpfs. > > > > (That patch contains three separate changes...) > > > > > > > > Should just this part, which changes '<' to '<=', be pushed upstream? > > > > > > Yes. I'm sure Andrea will take care of that himself. > > > > That fix is contained within fix-for-mpol-mm-corruption-on-tmpfs.patch > > anyway, isn't it? > > Yes; and Chuck is right that it's three patches not one.
Always a source of hassles, that.
> I think at the least you should split it by file into mm/shmem.c > and mm/mempolicy.c parts, they're entirely independent. > > I've seen Andi's ack on the '<=' fix, > I've not seen his ack on the mempolicy optimizations.
Sigh. OK, I'll split the patch into three and will feed the `<=' fix and the symlink fix into 2.6.10. The mempolicy optimisation can await 2.6.11.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |