Messages in this thread | | | Date | Tue, 16 Nov 2004 10:20:38 +0100 (CET) | From | Tim Schmielau <> | Subject | Re: [PATCH] __init and i386 timers |
| |
On Mon, 15 Nov 2004, john stultz wrote:
> On Sat, 2004-11-13 at 15:22, Andries Brouwer wrote: > > The i386 timers use a struct timer_opts that has a field init > > pointing at a __init function. The rest of the struct is not __init. > > > > Nothing is wrong, but if we want to avoid having references to init stuff > > in non-init sections, some reshuffling is needed. > > Ugh. I understand the goal, but the resulting code indirection turns my > stomach a bit. > > Although do take my criticism lightly, as right off I don't have a > better suggestion other then to just yank the __init attribute from the > initialization functions. I'm just not sure the savings is worth the > added staple-gunned complexity. Might there be a better way?
I'd second. We already have too much complexity in the time related code.
Tim - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |