Messages in this thread | | | Date | Tue, 16 Nov 2004 00:41:25 -0800 | From | Chris Wright <> | Subject | Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET |
| |
* Stephen Smalley (sds@epoch.ncsc.mil) wrote: > On Sun, 2004-11-14 at 13:13, Ross Kendall Axe wrote: > > With CONFIG_SECURITY_NETWORK=y and CONFIG_SECURITY_SELINUX=y, using > > SOCK_SEQPACKET unix domain sockets causes an oops in the superfluous(?) > > call to security_unix_may_send in sock_dgram_sendmsg. This patch avoids > > making this call for SOCK_SEQPACKET sockets. > > I'd prefer to track down the actual issue in the SELinux code and > correct it than just omit the security hook call entirely. Do you have > the Oops output and a trivial test case? Thanks.
Well, there is one simple case that will trigger the Oops. Send a SEQPACKET to a connected but not yet accepted socket. In this case other->sk_socket is still NULL, and SELinux will deref the NULL pointer in selinux_socket_may_send() when geting other_isec. There is already a check in unix_stream_connect, which is all that's used for normal unix stream sockets. But the seqpacket socket then uses unix_dgram_sendmsg, so triggers the may_send check as well.
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |