Messages in this thread | | | Date | Tue, 16 Nov 2004 17:18:54 +0000 | From | Alasdair G Kergon <> | Subject | Re: 2.6.10-rc2 dm.c dm_init unresolved reference to _exits |
| |
On Mon, Nov 15, 2004 at 12:23:23PM +0100, Andries Brouwer wrote: > On Mon, Nov 15, 2004 at 03:36:21PM +1100, Keith Owens wrote: > > drivers/md/dm.c dm_int refers to _exits which is defined as __exitdata. > > With CONFIG_HOTPLUG=n, __exitdata is discarded > Yes - thanks for reminding - thought of that yesterday night > but forgot again the next morning.
In fact that's the second time someone's introduced a bug like that in this code: to save someone else from doing it again, please also add a comment that the exit functions may be called during init (if an init function fails).
Alasdair -- agk@redhat.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |