Messages in this thread | | | Date | Mon, 15 Nov 2004 13:27:49 -0800 | From | Chris Wright <> | Subject | Re: [Patch] export sched_setscheduler() for kernel module use |
| |
* Dean Nelson (dcn@sgi.com) wrote: > On Mon, Nov 15, 2004 at 10:58:01AM -0800, Chris Wright wrote: > > * Dean Nelson (dcn@sgi.com) wrote: > > > +int do_sched_setscheduler(pid_t pid, int policy, struct sched_param __user *param) > > > > this should be static. > > You're right. I made another change in that one now passes the task_struct > pointer to sched_setscheduler() instead of the pid. This requires that > the caller of sched_setscheduler() hold the tasklist_lock. The new patch > for people's feedback follows.
This now means callers of sched_setscheduler hold tasklist_lock, also with irq off. I think it's safer to let the core function do that. It's a touchy area that's ripe for deadlock.
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |