lkml.org 
[lkml]   [2004]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/acpi: remove unused exported functions
Hi!

> > The patch below completely removes 7 functions that were
> > EXPORT_SYMBOL'ed but had exactly zero users in the kernel and makes
> > another one that was previously EXPORT_SYMBOL'ed static.
> >
> > It also removes another unused global function to completely remove
> > drivers/acpi/hardware/hwtimer.c which contained no function used
> > anywhere in the kernel.
> >
> > Please comment on whether this patch is correct or whether in-kernel
> > users of these functions are pending.
> >
> >
> > diffstat output:
> > drivers/acpi/acpi_ksyms.c | 8 -
> > drivers/acpi/events/evxfevnt.c | 191 -----------------------------
> > drivers/acpi/hardware/Makefile | 2
> > drivers/acpi/hardware/hwtimer.c | 200
> > -------------------------------
> > drivers/acpi/resources/rsxface.c | 52 --------
> > drivers/acpi/scan.c | 6
> > drivers/acpi/utilities/utxface.c | 89 -------------
> > include/acpi/achware.h | 17 --
> > include/acpi/acpi_bus.h | 1
> > include/acpi/acpixf.h | 24 ---
> > 10 files changed, 6 insertions(+), 584 deletions(-)
>
> No, I can't apply this one as-is.
> Some of these routines are not called now
> simply because Linux/ACPI is evolving and we don't
> yet take advantage of some of the things supported
> by ACPICA core we use.

I believe right thing to do is remove them now, and re-add them later
(if they are ever needed).

Single line patch somewhere which happens to pull whole evxfevnt.c
would be pretty "expensive", but would not certainly look so...

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.086 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site