lkml.org 
[lkml]   [2004]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 4/10] s390: network driver.
Martin Schwidefsky wrote:
> [patch 4/10] s390: network driver.
>
> From: Thomas Spatzier <tspat@de.ibm.com>
> From: Peter Tiedemann <ptiedem@de.ibm.com>
>
> network driver changes:
> - qeth: return -EINVAL if an skb is too large.
> - qeth: don't call netif_stop_queue after cable pull. Drop the
> packets instead.


You should be using netif_carrier_{on,off} properly, and not drop the
packets. When (if) link comes back, you requeue the packets to hardware
(or hypervisor or whatever). Your dev->stop() should stop operation and
clean up anything left in your send/receive {rings | buffers}.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.025 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site