Messages in this thread | | | Date | Wed, 10 Nov 2004 16:24:01 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] fix platform_rename_gsi related ia32 build breakage |
| |
On Wed, 10 Nov 2004, Arnaldo Carvalho de Melo wrote: > > This one compiles and links OK.
Including when CONFIG_ACPI_BOOT is set? Does it see the prototype then? Looks like <asm/acpi.h> should be included, but I assume it gets included some other way?
Quite frankly, I think the whole thing is broken. #ifdef's inside code is _evil_, and "platform_rename_gsi()" doesn't make sense as a name. I'll apply your patch, but quite frankly, I think the ACPI layer is doing crap.
Len, can you please use a more descriptive name, and have it be always defined (make it an inline function that just becomes a no-op or something).
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |