Messages in this thread | | | Date | Mon, 1 Nov 2004 21:21:43 +0100 (MET) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include |
| |
On Sun, 31 Oct 2004, Linus Torvalds wrote: > Not only is that include not recursive, but it immediately breaks any SMP
It's not immediately recursive, but <linux/sched.h> includes about everything and the kitchen sink, causing fatal problems on m68k since 2.6.9*...
> compile because that header file _needs_ the definition of "task_struct".
Sorry, forgot about SMP.
So we have to move the definition of "task_struct" to <linux/task_struct.h> first, to avoid include hell. Cfr. what Roman Zippel is working on.
> I applied it without realizing it, but I'll undo it and I hope you fix > your broken tree so that I don't ever have to see this broken patch > again..
Don't worry, it has been moved to my POSTPONED queue :-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |