Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH] document mmiowb and readX_relaxed a bit more in deviceiobook.tmpl | Date | Mon, 1 Nov 2004 09:36:10 -0800 |
| |
On Friday, October 29, 2004 7:35 pm, Benjamin Herrenschmidt wrote: > On Fri, 2004-10-29 at 17:47 -0700, Jesse Barnes wrote: > > This is a small patch to deviceiobook.tmpl to describe the new mmiowb > > routine a bit more completely. I've also updated it to provide pointers > > to drivers that do write flushing, use mmiowb, and use the readX_relaxed > > routines. > > It's all good, but your semantics and description are very tailored to > your specific arch problem vs. unlock. > > What about my suggestion of defining a broader semantic of mmiowb() as > beeing a barrier ordering MMIOs vs. the rest of the world ? The later > includes stores to memory _and_ spinlock/unlock.
Yeah, that's ok with me, just be sure to update the documentation when you add the PPC stuff. Seems like a worthwhile optimization.
thanks, Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |