Messages in this thread | | | Date | Sat, 10 Jan 2004 08:43:55 +1300 | From | Nigel Cunningham <> | Subject | Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables |
| |
You might be right. I was just being consistent with the other definitions. Andrew? Benjamin?
Regards,
Nigel
On Sat, 2004-01-10 at 08:22, Richard B. Johnson wrote: > On Sat, 10 Jan 2004, Nigel Cunningham wrote: > > > This patch makes console X and Y coordinates unsigned, rather than > > signed. Issues with wide (> 128 char?) consoles, seen when developing > > Software Suspend's 'nice display' are thus fixed. A brief examination of > > related code showed that this use of signed variables was the exception > > rather than the rule. > > > > Regards, > > > > Nigel > [SNIPPED...] > > Question: Shouldn't we be using "size_t" for unsigned int, and > "ssize_t" for signed? If the "ints" are going to be changed, > they probably should be changed only once. As I recall, size_t > was the largest unsigned int that would fit into a register and > ssize_t was the largest signed int that would fit. > > Cheers, > > Dick Johnson > Penguin : Linux version 2.4.22 on an i686 machine (797.90 BogoMips). > Note 96.31% of all statistics are fiction. > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- My work on Software Suspend is graciously brought to you by LinuxFund.org. [unhandled content-type:application/pgp-signature] | |