Messages in this thread | | | Date | Tue, 6 Jan 2004 12:33:30 +0100 | From | Christophe Saout <> | Subject | Re: Possibly wrong BIO usage in ide_multwrite |
| |
On Tue, Jan 06, 2004 at 12:59:52AM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Monday 05 of January 2004 23:51, Christophe Saout wrote: > > Remember? Can bio be NULL somewhere? Or what do you mean? It's our > > scratchpad and ide_multwrite never puts a NULL bio on it. > > After last sector of the whole transfer is processed ide_multwrite() will set > it to NULL.
No, it doesn't.
> /* end early early we ran out of requests */ > if (!bio) { > mcount = 0; > } else { > rq->bio = bio; > rq->nr_cbio_segments = bio_segments(bio); > rq->current_nr_sectors = bio_cur_sectors(bio); > rq->hard_cur_sectors = rq->current_nr_sectors; > }
rq->bio is only set if bio is not NULL.
> Next IRQ is only ACK of previous datablock, no transfer happens.
You're right, the bi_idx resetting might be redundant but since bio is never NULL an additional check is superfluous.
> Move it before the comment.
Ok. I will repost when the issue above is worked out.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |