lkml.org 
[lkml]   [2004]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] oprofile per-cpu buffer overrun
Philippe Elie <phil.el@wanadoo.fr> wrote:
>
> Hi Andrew,
>
> In a ring buffer controlled by a read and write positions we
> can't use buffer_size but only buffer_size - 1 entry,

you can, actually.

> the last
> free entry act as a guard to avoid write pos overrun. This bug
> was hidden because the writer, oprofile_add_sample(), request
> one more entry than really needed.
>
>...
> diff -u -p -r1.9 cpu_buffer.c
> --- drivers/oprofile/cpu_buffer.c 26 May 2003 04:42:54 -0000 1.9
> +++ drivers/oprofile/cpu_buffer.c 24 Jan 2004 21:07:03 -0000
> @@ -86,9 +86,9 @@ static unsigned long nr_available_slots(
> unsigned long tail = b->tail_pos;
>
> if (tail > head)
> - return tail - head;
> + return (tail - head) - 1;
>
> - return tail + (b->buffer_size - head);
> + return tail + (b->buffer_size - head) - 1;
> }

When implementing a circular buffer it is better to not constrain the head
and tail indices - just let them grow and wrap without bound. You only need
to bring them in-bounds when you actually use them to index the buffer.

This way,

- head-tail is always the amount of used space, no need to futz around
handling the case where one has wrapped and the other hasn't.

- you get to use all of the buffer, because the cases head-tail == 0
(empty) and head-tail == bufsize (full) are now distinguishable.

It helps if the buffer size is a power of two, of course, but integer
modulus is pretty quick.

All the net drivers and the printk log buffer implement their ring buffers
in this way; it works nicely.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.051 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site