Messages in this thread | | | Date | Tue, 20 Jan 2004 10:30:54 +0100 | From | Gerd Knorr <> | Subject | Re: [patch] v4l-05 add infrared remote support |
| |
On Tue, Jan 20, 2004 at 12:55:39PM +1100, Rusty Russell wrote: > In message <20040115115611.GA16266@bytesex.org> you write: > > +static int repeat = 1; > > +MODULE_PARM(repeat,"i"); > > +MODULE_PARM_DESC(repeat,"auto-repeat for IR keys (default: on)"); > > + > > +static int debug = 0; /* debug level (0,1,2) */ > > +MODULE_PARM(debug,"i"); > > Please replace the MODULE_PARM lines with the modern form: > > module_param(repeat, bool, 0644); > module_param(debug, int, 0644);
No. The code in question must also build on 2.4 kernels which don't have module_param(). And I don't want to clutter up the code with #ifdefs unless I absolutely have to.
I'll do for the bttv ir support, that is 2.6 only anyway due to the usage of tasklets.
Gerd
-- "... und auch das ganze Wochenende oll" -- Wetterbericht auf RadioEins - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |