Messages in this thread Patch in this message | | | Date | Thu, 15 Jan 2004 22:44:16 +0100 | From | Romain Lievin <> | Subject | [PATCH] "gconfig" removed root folder... |
| |
Hi,
> Today I downloaded 2.6.1 kernel and tried to configure it with "make > gconfig". After all changes I selected "Save As" and clicked "/root" > folder to save in. Then I clicked "OK", without giving a file name. I > expected that it opens root folder and lists contents. But this magic > configurator removed (rm -Rf) my root folder and created a file named > "root". It was a terrible experience!..
A patch against 2.6.1 which fix this problem. Please apply...
Thanks, Romain
===========================[cut here]========================== diff -Naur linux-2.6.1/scripts/kconfig/gconf.c linux/scripts/kconfig/gconf.c --- linux-2.6.1/scripts/kconfig/gconf.c 2004-01-15 21:45:22.000000000 +0100 +++ linux/scripts/kconfig/gconf.c 2004-01-15 22:36:55.000000000 +0100 @@ -23,6 +23,9 @@ #include <unistd.h> #include <time.h> #include <stdlib.h> +#include <sys/types.h> +#include <sys/stat.h> + //#define DEBUG @@ -643,9 +646,18 @@ store_filename(GtkFileSelection * file_selector, gpointer user_data) { const gchar *fn; + gchar trailing; + struct stat sb; fn = gtk_file_selection_get_filename(GTK_FILE_SELECTION (user_data)); + + /* protect against 'root directory' bug */ + trailing = fn[strlen(fn)-1]; + if(stat(fn, &sb) == -1) return; + if(S_ISDIR(sb.st_mode)) + if(trailing != '/') + strcat((char *)fn, "/"); if (conf_write(fn)) text_insert_msg("Error", "Unable to save configuration !"); -- Romain Liévin (roms): <roms@tilp.info> Web site: http://tilp.info "Linux, y'a moins bien mais c'est plus cher !"
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |