Messages in this thread | | | Date | Tue, 13 Jan 2004 21:59:18 +0000 | From | Dave Jones <> | Subject | Re: Cleanups for powernow-k8 |
| |
On Tue, Jan 13, 2004 at 10:51:49PM +0100, Pavel Machek wrote:
> powernow-k8 uses strange kind of comments
comments part I kinda agree with, though its not critical..
> and is way too verbose.
I agree that something like that output belongs more in x86info, or a standalone tool, but I think Paul wanted to keep debugging stuff there for the time being. Maybe silence it, and have it enabled with a 'debug' module param ? Paul ?
> Also powernow-k7 should just shut up when it is monolithic > kernel and cpu is not k7.
Agreed, applied.
> @@ -637,6 +629,7 @@ > } > > if ((numps <= 1) || (batps <= 1)) { > + /* FIXME: Is this right? I can see one state on battery, two states total as an usefull config */ > printk(KERN_ERR PFX "only 1 p-state to transition\n"); > return -ENODEV; > } > the test probably should be numps <= 1 only, but it does not matter as > we force numps = batps]
1 state on battery sounds odd. Buggy BIOS ?
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |