Messages in this thread | | | Date | Mon, 12 Jan 2004 20:46:25 +1100 | Subject | Re: [I810_AUDIO] 1/x: Fix wait queue race in drain_dac | From | Herbert Xu <> |
| |
On Sun, Jan 11, 2004 at 04:00:41PM -0500, Jeff Garzik wrote: > > Thanks much for these i810_audio patches. I've been meaning to review > them in-depth for some time.
Thanks a lot for reviewing them.
> Could you be kind and "spell out" the patch-1 race for me?
Prior to the patch, if an interrupt occured between the count check and the setting of the current state the wait will timeout instead of waking up immediately.
> Also, it seems to me that you would want to check for signal_pending() > (a) just after the schedule_timeout(), and > (b) -after- testing the 'signals_allowed' variable ;-)
schedule() already checks for signals.
Cheers, -- Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ ) Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |