Messages in this thread | | | Date | Tue, 9 Sep 2003 13:40:14 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] use size_t for the broken ioctl numbers |
| |
On Mon, Sep 08 2003, Andries Brouwer wrote: > On Sun, Sep 07, 2003 at 07:22:48AM +0100, Matthew Wilcox wrote: > > > Clearly it's too late to change the ioctl definitions, but we can at > > least stop people from copying them and making the same mistake. > > > -#define BLKELVSET _IOW(0x12,107,sizeof(blkelv_ioctl_arg_t))/* elevator set */ > > +#define BLKELVSET _IOW(0x12,107,size_t)/* elevator set */ > > Here we lose information - I don't like that. > Often it is important to know what kind of argument an ioctl has, > and that info should be easy to find.
Just kill them, they are not used.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |