Messages in this thread | | | From | Benjamin Herrenschmidt <> | Date | Tue, 09 Sep 2003 23:09:32 +0200 | Subject | Re: [PATCH] Power: call save_state on PCI devices along with suspend |
| |
On Tue, 2003-09-09 at 23:04, Patrick Mochel wrote: > > Don't we want that ? It will help if any driver currently relies on > > the save_state callback to be called... > > Bah, this patch slipped my mind. How many drivers actually use > ->save_state()? From a quick look, it looks like: > > 1. drivers/ide/pci/sc1200.c > 2. drivers/net/irda/vlsi_ir.c > 3. drivers/scsi/nsp32.c > 4. drivers/serial/8250_pci.c > > Of those, only (1) actually does anything interesting. (2) and (3) only > print a message, and (4) appears to be trivial to fold into ->suspend(). > > What do you think about just fixing those up?
Well... that wouldn't help with off-tree drivers...
What I mean here is that our PCI driver API defines save_state, we shall either "support" it some way, or get rid of it completely... but then we lose the ability to move a PCI driver back & forth with 2.4 ... (do we care ?)
If you prefer just fixing those 4 ones, then let's get rid of the save_state field in pci_driver completely...
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |