Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 09 Sep 2003 17:21:34 -0300 | From | Felipe W Damasio <> | Subject | Re: [PATCH] Missing memory barrier on net/core/dev.c |
| |
Hi,
David S. Miller wrote: > On Tue, 09 Sep 2003 14:58:47 -0300 > Felipe W Damasio <felipewd@terra.com.br> wrote: > > >> I *think* net/core/dev.c is missing a mb() before calling >>schedule_timoeut. > > I have another patch in my queue from Andrew Morton that > removes the TASK_RUNNING setting altogether, schedule_timeout() > always returns with the task in that state.
Ok, although that was not the main point of the patch :)
What about the "set_current_state" before calling schedule_timeout. Isn't that mb() needed?
Cheers,
Felipe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |