lkml.org 
[lkml]   [2003]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] mtime&ctime updated when it should not
Hi!

> > > > Isn't this sufficient?
> > > I think it is not (I tried exactly the same patch but it didn't work)
> > > - the problem is that vmtruncate() is called when prepare_write() fails
> > > and this function also updates mtime and ctime.
> >
> > Oh OK.
> >
> > So we would need to change each filesystem's ->truncate to not update the
> > inode times, then move the timestamp updating up into vmtruncate().
> That is one solution. The other (less intrusive) is to just store old
> time stamps and restore times when you find out that write failed.

What if userspace sees the new time for a short while? That would certainly be
a bug...
Pavel

--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.045 / U:2.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site