Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 30 Sep 2003 16:36:02 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2.5] USB speedtouch: reduce memory usage |
| |
On Mon, Sep 29, 2003 at 11:37:08PM +0200, Duncan Sands wrote: > Currently, incoming packets are reassembled in a sk_buff which is then > sent to the upper layers. The sk_buff needs to be big enough to hold the > worst case packet since the size cannot be known in advance. This would > not be so bad if the ATM layer paid attention to the mtu (usually 1500 bytes), > but for some reason it blithely ignores it and typically passes 9188 bytes > as the maximum size. This means that at best 5/6 of the space in every > sk_buff is wasted. So instead let's just allocate an assembly buffer (sarb) > which gets reused for every packet, and copy each assembled packet into > a minimally sized sk_buff before sending. > > > speedtch.c | 106 +++++++++++++++++++++++++++++++------------------------------ > 1 files changed, 55 insertions(+), 51 deletions(-)
Applied, thanks.
greg k-h
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |