Messages in this thread | | | Date | Sun, 28 Sep 2003 11:24:45 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] i386 do_machine_check() is redundant. |
| |
On Sun, 28 Sep 2003, Brian Gerst wrote: > > Use machine_check_vector in the entry code instead.
This is wrong. You just lost the "asmlinkage" thing, which means that it breaks when asmlinkage matters.
And yes, asmlinkage _can_ matter, even on x86. It disasbles regparm, for one thing, so it makes a huge difference if the kernel is compiled with -mregparm=3 (which used to work, and which I'd love to do, but gcc has often been a tad fragile).
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |