Messages in this thread | | | Date | Sat, 27 Sep 2003 13:15:58 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] helper for device list traversal |
| |
On Sat, Sep 27, 2003 at 01:34:15PM +0200, Geert Uytterhoeven wrote: > On Thu, 25 Sep 2003, Linux Kernel Mailing List wrote: > > ChangeSet 1.1217.10.16, 2003/09/25 12:10:17-05:00, hch@lst.de > > > > [PATCH] helper for device list traversal > > > > This patch adds shost_for_each_device(). It's used to abstract out > > scsi_host.my_devices traversal. The next step will be to replace > > the current simple implementation with one that's fully locked down > > an reference counted. > > Is this what we should use to fix the currently broken list traversal[*] in > drivers/scsi/{a2091,gvp11,53c7xx}.c? > > Currently ut uses > > struct Scsi_Host *instance; > for (instance = first_instance; instance && > instance->hostt == xxx_template; instance = instance->next) > > bust Scsi_Host.next was removed a while ago...
Urgg. This is totally hosed. The drivers should be fixed up to pass the right host to request_irq and the only handle the right one in the isr instead of walking a lits of all hosts of that template..
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |